[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

[David Goldman via Phabricator via cfe-commits]

dgoldman updated this revision to Diff 277103.
dgoldman added a comment.

Move up null check


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83501/new/

https://reviews.llvm.org/D83501

Files:
  clang-tools-extra/clangd/FindTarget.cpp


Index: clang-tools-extra/clangd/FindTarget.cpp
===================================================================
--- clang-tools-extra/clangd/FindTarget.cpp
+++ clang-tools-extra/clangd/FindTarget.cpp
@@ -282,6 +282,8 @@
       D = CID->getCategoryDecl();
       Flags |= Rel::Underlying;
     }
+    if (!D)
+      return;
 
     if (const Decl *Pat = getTemplatePattern(D)) {
       assert(Pat != D);
@@ -290,8 +292,6 @@
       Flags |= Rel::TemplateInstantiation;
     }
 
-    if (!D)
-      return;
     report(D, Flags);
   }
 



Index: clang-tools-extra/clangd/FindTarget.cpp
===================================================================
--- clang-tools-extra/clangd/FindTarget.cpp
+++ clang-tools-extra/clangd/FindTarget.cpp
@@ -282,6 +282,8 @@
       D = CID->getCategoryDecl();
       Flags |= Rel::Underlying;
     }
+    if (!D)
+      return;
 
     if (const Decl *Pat = getTemplatePattern(D)) {
       assert(Pat != D);
@@ -290,8 +292,6 @@
       Flags |= Rel::TemplateInstantiation;
     }
 
-    if (!D)
-      return;
     report(D, Flags);
   }
 

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits