Thanks for letting me know Eric. What test fails exactly? What config? De : Eric Christopher <echri...@gmail.com> Envoyé : July 10, 2020 7:04 PM À : reviews+d80833+public+da87cf0eabdca...@reviews.llvm.org; Alexandre Ganea via Phabricator <revi...@reviews.llvm.org> Cc : Alexandre Ganea <alexandre.ga...@ubisoft.com>; Hans Wennborg <h...@chromium.org>; Adrian McCarthy <amcca...@google.com>; Martin Storsjo <mar...@martin.st>; Amy Huang <akhu...@google.com>; dma...@mozilla.com; john.rea...@vmssoftware.com; ztur...@roblox.com; 8888...@gmail.com; llvm-commits <llvm-comm...@lists.llvm.org>; stefan.reinal...@molecular-matters.com; Ulrich Weigand <ulrich.weig...@de.ibm.com>; mlek...@skidmore.edu; Clang Commits <cfe-commits@lists.llvm.org>; Han Shen <shen...@google.com> Objet : Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record
I'm seeing tests fail with a crash. Can we revert the patch and attempted fixes and start working from there? Stacktrace for the curious :) @ 0x56420187cbbe llvm::MCStreamer::emitIntValue() @ 0x5641fec38899 llvm::MCStreamer::emitInt16() @ 0x5641ff73b337 llvm::CodeViewDebug::emitCompilerInformation() @ 0x5641ff73ac73 llvm::CodeViewDebug::endModule() @ 0x5641ff718e83 llvm::AsmPrinter::doFinalization() @ 0x5642016fd9ca llvm::FPPassManager::doFinalization() @ 0x5642016f954e (anonymous namespace)::MPPassManager::runOnModule() -eric On Tue, Jun 30, 2020 at 11:56 AM Alexandre Ganea via Phabricator via cfe-commits <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>> wrote: aganea added a comment. In D80833#2109172 <https://reviews.llvm.org/D80833#2109172>, @uweigand wrote: > Hmm, with clang-cl it seems the driver is trying to use this: > Target: s390x-pc-windows-msvc > which of course doesn't exist. Not sure what is supposed to be happening > here, but it seems that it's falling back on s390x-linux since on s390x, > Linux is currently the only supported OS. I'm seeing some of the tests are setting the target explicitly `%clang_cl --target=x86_64-windows-msvc`. Would that work on your machine? Or should I do `UNSUPPORTED: s390x` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits