sammccall added inline comments.
================ Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:205 + +TEST(SemanticSelection, FoldingRanges) { + const char *Tests[] = { ---------------- nit, the test is usually named after the API/feature, so this should be TEST(FoldingRanges, All) or so Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/ https://reviews.llvm.org/D82436 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits