balazske marked an inline comment as done.
balazske added inline comments.
================
Comment at: clang/test/Analysis/stream.c:274-284
// Check that "location uniqueing" works.
// This results in reporting only one occurence of resource leak for a stream.
void check_leak_noreturn_2() {
FILE *F1 = tmpfile();
if (!F1)
return;
if (Test == 1) {
----------------
NoQ wrote:
> balazske wrote:
> > Szelethus wrote:
> > > Why did this change? Is there a sink in the return branch?
> > The change is probably because D83115. Because the "uniqueing" one resource
> > leak is reported from the two possible, and the order changes somehow
> > (probably not the shortest is found first).
> The shortest should still be found first. I strongly suggest debugging this.
> Looks like a bug in suppress-on-sink.
There is no code that ensures that the shortest path is reported. In this case
one equivalence class is created with both bug reports. If `SuppressOnSink` is
false the last one is returned from the list, otherwise the first one
(`PathSensitiveBugReporter::findReportInEquivalenceClass`), this causes the
difference (seems to be unrelated to D83115).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83120/new/
https://reviews.llvm.org/D83120
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
