steakhal marked an inline comment as done.
steakhal added a comment.
Besides @balazske's comments, looks good to me.
================
Comment at:
clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:504-505
- if (NewState && NewState != State)
+ if (NewState && NewState != State) {
+ ++NumCaseApplied;
C.addTransition(NewState);
----------------
At first, it was strange to check `NewState != State` since the `addTransition`
will do this check regardless.
Then I recognized the statistic increment.
It makes sense to count only the new state transitions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78189/new/
https://reviews.llvm.org/D78189
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
