sammccall added a comment.

Tried this out in D84012 <https://reviews.llvm.org/D84012>/D84009 
<https://reviews.llvm.org/D84009>. Works pretty well, and I think the API is a 
useful and natural addition to TokenBuffer.
Maybe this is too much complexity though?

(Mostly here i'm worrying about the case when the user hits "select all" in 
their editor and we get a code action request or so - it seems wasteful to 
query the token buffer for every token in the file separately. But maybe this 
is in the noise in any case).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83508/new/

https://reviews.llvm.org/D83508



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to