Szelethus added a comment.

I hope you don't mind if I bring up a point you mentioned during a daily 
meeting.

> The error checking shouldn't be present on one of execution, but rather on 
> all of them.

I think your recent comment highlights why that wouldn't be sufficient, 
unfortunately. Also, the else branch will have be accounted for, good forward 
thinking.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72705/new/

https://reviews.llvm.org/D72705



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to