sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/test/AST/ast-dump-recovery.c:20
+// CHECK-NEXT: `-DeclRefExpr {{.*}} 'a'
+int prefix_inc = ++a;
+
----------------
why is this an interesting distinct case vs the one above?
================
Comment at: clang/test/AST/ast-dump-recovery.c:39
+// CHECK-NEXT: `-FloatingLiteral {{.*}} 'double'
+int unary_bitinverse = ~(a + 0.0);
+
----------------
and this one
================
Comment at: clang/test/AST/ast-dump-recovery.c:55
+ // CHECK-NEXT: `-DeclRefExpr {{.*}} 'a' 'const int'
+ static int foo = a++; // verify no crash on local static var decl.
+}
----------------
may or may not want to separate the crash tests out. Up to you, can do this
later
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84146/new/
https://reviews.llvm.org/D84146
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
