riccibruno added a comment. In D84090#2162389 <https://reviews.llvm.org/D84090#2162389>, @MyDeveloperDay wrote:
> Nit:clang-format the patch > > Here is a Tip as to what I do (In case it helps other): > > 1. I generate the diff off the staged items so I've already git added all the > files I'm working on. > 2. then I can do `git clang-format`, this will fix up any files in the diff > that need formatting (you'll need to git add them again if they have) > 3. I then check the documentation builds with `/usr/bin/sphinx-build -n > ./docs ./html` (if the review contains rst files) > 4. then I do `git diff --cached -U999999 > patch_to_submitt.diff` > 5. I check the patch to ensure I'm not changing the mode of the files with > `grep -A0 -B2 "new mode" patch_to_submitt.diff` > 6. and this is the patch_tosubmitt.diff I upload to the review > > These steps try to reduce the number of review fails I get based on > clang-format issues (all of this is scripted so making a patch is repeatable, > quick and easy and all based off whats in my staged area) > > Apart from that this patch LGTM (Before and After are good names) > > But please clang-format before pushing (including the tests) That's useful, thank you! I was not aware of `git clang-format`, which unlike `clang-format-diff` seems to respect `.clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84090/new/ https://reviews.llvm.org/D84090 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits