JonChesterfield marked 4 inline comments as done. JonChesterfield added inline comments.
================ Comment at: clang/lib/Headers/__clang_hip_math.h:561 inline double abs(double __x) { return __ocml_fabs_f64(__x); } +#endif __DEVICE__ ---------------- yaxunl wrote: > jdoerfert wrote: > > Nit: You mix the C and C++ math declarations in this file, while possible, > > I somehow thing the cuda_{cmath/math} split is nicer. > right Open to me implementing that in a later patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84476/new/ https://reviews.llvm.org/D84476 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits