hokein added a comment. mostly good, just a concern about the linking dependence.
================ Comment at: clang-tools-extra/clangd/CMakeLists.txt:143 clangToolingSyntax + clangdRemoteIndex ) ---------------- the dependence here seems to be a layer violation. we add remote-index library when linking the clangDaemon, but `clangdRemoteIndex` *depends* on `clangDaemon` I think we should do this when linking the clangd binary (in `clangd/tool/CMakeLists.txt`). ================ Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:462 +opt<std::string> ProjectRoot{ + "project-path", + cat(Features), ---------------- nit: project-path -> project-root. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits