riccibruno added a comment.

In D84656#2175813 <https://reviews.llvm.org/D84656#2175813>, @erichkeane wrote:

> I looked through the code changes, and they all seem quite mechanical.  I 
> believe they are all correct.
>
> After reading through the test changes, I believe that this change is 
> strictly an improvement thanks to printing the template arguments. Therefore, 
> I don't believe I know of any way that htis is controversial.
>
> That said, because I'm approving so quickly after submission, please give at 
> least a few hours before committing to give the other reviewers a chance to 
> take a look.


I will. Thanks for the review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84656/new/

https://reviews.llvm.org/D84656



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to