[PATCH] D83997: [os_log] Improve the way we extend the lifetime of objects passed to __builtin_os_log_format

[Gabor Marton via Phabricator via cfe-commits]

martong added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:8000
       return ExprWithCleanups::CleanupObject(cast<CompoundLiteralExpr>(*R));
+  } else if (auto *ICE = From.dyn_cast<ImplicitCastExpr *>()) {
+    if (Expected<Expr *> R = Import(ICE))
----------------
I am not sure how this hunk is related to `os_log`. Maybe you mistakenly mixed 
another unrelated change into this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83997/new/

https://reviews.llvm.org/D83997



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits