hokein added inline comments.
================ Comment at: clang-tools-extra/clangd/FindTarget.cpp:172 std::vector<const NamedDecl *> resolveDependentExprToDecls(const Expr *E) { assert(E->isTypeDependent()); if (const auto *ME = dyn_cast<CXXDependentScopeMemberExpr>(E)) { ---------------- @nridge, the assertion is not true anymore, since we have extended it to support possibly-non-dependent expressions (`callExpr`, `MemberExpr`). we hit this assert when opening `clang/include/clang/ASTMatchers/ASTMatchers.h`. I think we probably need to remove it and rename related function names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits