yamauchi added inline comments.

================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:661
+    } Data;
+    Data.N = (uint64_t)SIVisitor.getNumOfSelectInsts();
+    JCH.update(Data.C);
----------------
MaskRay wrote:
> MaskRay wrote:
> > `#include "llvm/Support/Endian.h"`
> > 
> > and use `support::endian::write64le(&Data.N, 
> > (uint64_t)SIVisitor.getNumOfSelectInsts())`
> Sorry, just use a plain `uint8_t C[8];` and `support::endian::write64le(C, 
> (uint64_t)SIVisitor.getNumOfSelectInsts())`
I went for the same style (using a vector) as the above code (line 642).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84782/new/

https://reviews.llvm.org/D84782

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to