vsavchenko added a comment.
Thanks for working on improving the quality of the codebase!
I again have to nitpick about the commit message, can you please change it to
"Simplify ..."?
================
Comment at: clang/lib/StaticAnalyzer/Core/SVals.cpp:135-149
-/// getAsSymbolicExpression - If this Sval wraps a symbolic expression then
-/// return that expression. Otherwise return NULL.
-const SymExpr *SVal::getAsSymbolicExpression() const {
- if (Optional<nonloc::SymbolVal> X = getAs<nonloc::SymbolVal>())
- return X->getSymbol();
-
- return getAsSymbol();
----------------
Oof, it's a mess!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85034/new/
https://reviews.llvm.org/D85034
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
