Could maybe add an assert along with the patch as well as an assert only test?
On Tue, Aug 4, 2020, 1:42 PM Sterling Augustine via Phabricator < revi...@reviews.llvm.org> wrote: > saugustine added a comment. > > The darwin-dsymutil.c tests this code path right now on line 33. I found > this error by running it under asan; otherwise it was fully latent. > > It seems pretty clear to me that when End == -1 (StringRef::npos), > creating a string ref from that is obviously a bug. > > I'm not even sure how to check for a failure. clang will almost never > crash; there is just a very subtle bounds violation or empty stringref. How > it manifests itself depends on subsequent usage of the stringref, and stack > layout. > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D85231/new/ > > https://reviews.llvm.org/D85231 > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
