echristo added a comment.

In D83273#2194842 <https://reviews.llvm.org/D83273#2194842>, @nickdesaulniers 
wrote:

> In D83273#2194832 <https://reviews.llvm.org/D83273#2194832>, @craig.topper 
> wrote:
>
>> It's a pretty nasty revert in our downstream tree where we have prototyped 
>> future ISAs. So I'd like a little time to take a look.
>>
>> @nickdesaulniers what cpu and fetaures are on your command lines. 
>> getImpliedDisabledFeatures should only be called if some feature is 
>> explicitly being disabled.
>
> Likely, as the kernel is very explicit to disable the use of all FP 
> extensions, see 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/Makefile#n57.
>   Maybe we could just set fewer flags, but there's still probably room for 
> improvement here, too.

That said, it's a 10% compile time regression for compiling something like the 
linux kernel or anything that's very explicit what flags they set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83273/new/

https://reviews.llvm.org/D83273

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to