MaskRay added inline comments.
================ Comment at: clang/lib/Basic/Targets/OSTargets.h:745 + if (this->PointerWidth == 64) { + Builder.defineMacro("__64BIT__"); + } ---------------- anirudhp wrote: > abhina.sreeskantharajan wrote: > > anirudhp wrote: > > > What about the `__LP64__` and the `_LP64` macros? > > These two are already added in the common code, so it would be redundant to > > add them again. > Alright Thanks! Omit braces https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85324/new/ https://reviews.llvm.org/D85324 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits