aaron.ballman accepted this revision.
aaron.ballman added a comment.
Continues to LGTM with your changes, but I did spot one tiny nit (no further
reviews needed from me).
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5346
+ if (!isNSStringType(VD->getType(), S.Context)) {
+ S.Diag(Loc, diag::err_nserrordomain_wrong_type) << DRE->getDecl();
+ return;
----------------
Minor nit, you can pass `VD` instead of `DRE->getDecl()` here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84005/new/
https://reviews.llvm.org/D84005
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
