hokein added inline comments.
================ Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:387 + !llvm::StringRef(ProjectRoot).endswith(llvm::sys::path::get_separator())) + ProjectRoot += llvm::sys::path::get_separator(); + ---------------- Instead of handling this in all callers, I think it might be better to move it to `Marshaller` and drop the ends-with-slash assertion there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85711/new/ https://reviews.llvm.org/D85711 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
