Tyker added a comment.
thanks for this,
here is a few comments aside from that this seems fine.
================
Comment at: clang/lib/Sema/SemaOverload.cpp:1761
+ llvm::SaveAndRestore<bool> DisableIITracking(
+ S.RebuildingImmediateInvocation, true);
+
----------------
I don't think RebuildingImmediateInvocation should be used here since we are
not rebuilding immediate invocations
setSuppressAllDiagnostics or TentativeAnalysisScope seems more adapted.
================
Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:131
+ consteval A() = default;
+ consteval ~A() = default; // expected-error {{destructor cannot be declared
consteval}}
+};
----------------
could you check that this diagnostic and those like it doesn't appear when the
struct A isn't instantiated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85933/new/
https://reviews.llvm.org/D85933
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
