kpdev42 added inline comments.
================ Comment at: llvm/include/llvm/ProfileData/InstrProfData.inc:676 #define VARIANT_MASK_CSIR_PROF (0x1ULL << 57) +#define VARIANT_MASK_INSTR_ENTRY (0x1ULL << 58) #define INSTR_PROF_RAW_VERSION_VAR __llvm_profile_raw_version ---------------- This revision is closed, so excuse me for the question: Files `./llvm/include/llvm/ProfileData/InstrProfData.inc` and `./compiler-rt/include/profile/InstrProfData.inc` should be two identical copies, as stated in their description. ``` * The file has two identical copies. The master copy lives in LLVM and * the other one sits in compiler-rt/lib/profile directory. To make changes * in this file, first modify the master copy and copy it over to compiler-rt. * Testing of any change in this file can start only after the two copies are * synced up. ``` Should we add `VARIANT_MASK_INSTR_ENTRY` to `compiler-rt` or change description? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84261/new/ https://reviews.llvm.org/D84261 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
