aprantl added inline comments.
================ Comment at: clang/include/clang/Serialization/ModuleManager.h:62 + struct EntryKey { + const FileEntry *Entry; ---------------- aprantl wrote: > Can you add a doxygen comment explaining why we compute our own hashing as > opposed to using the FileEntry pointer? Basically what you wrote in the description of the review... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85981/new/ https://reviews.llvm.org/D85981 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits