aaron.ballman added inline comments.
================ Comment at: clang/test/Modules/Inputs/inherit-attribute/b.h:3 + +class Foo; + ---------------- Does this forward declaration impact the test? I can't quite tell whether this exists to test that the attribute is attached to the non-defining redeclaration or not. (One way to make it more clear would be to have a less greedy regex in `inherit-attribute.cpp` so we can see the source location where the declarations are coming from.) ================ Comment at: clang/test/Modules/inherit-attribute.cpp:3 +// RUN: %clang_cc1 -fmodules -triple x86_64-pc-windows-msvc-unknown -I%S\Inputs\inherit-attribute -fmodules-cache-path=%t \ +// RUN: -fimplicit-module-maps -fmodules-local-submodule-visibility -verify %s -ast-dump-all \ +// RUN: | FileCheck %s ---------------- You can drop the `-verify` and `// expected-no-diagnostics` as they don't add anything to the test coverage. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83174/new/ https://reviews.llvm.org/D83174 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
