vsapsai marked an inline comment as done. vsapsai added a comment. Thanks for the review.
================ Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:700 + "no module named '%0' %select{found|in '%2'}1, " + "expected parent module to be defined before the submodule">; def err_mmap_top_level_inferred_submodule : Error< ---------------- bruno wrote: > vsapsai wrote: > > Not sure about this second part of the message ("expected..."). Wanted to > > make it more actionable but not entirely happy with the wording. Any > > suggestions including removal are welcome. > How about `, parent module must be defined before the submodule`? Thanks, I think it is more direct and slightly more concise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84458/new/ https://reviews.llvm.org/D84458 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits