ctetreau added a comment.

In D86065#2241146 <https://reviews.llvm.org/D86065#2241146>, @david-arm wrote:

> Hi @ctetreau, ok for now I'm going to completely remove the operators and 
> revert the code using those operators to how it was before. ...

This is probably for the best.

In D86065#2241146 <https://reviews.llvm.org/D86065#2241146>, @david-arm wrote:

> ... I'm not sure what you mean about the predicate functions ...

I'm referring to providing some built in way to std::sort a collection of 
ElementCount or have a std::set<ElementCount>. By default, C++ wants to use 
operator< for this, which I believe was the original motivation for the 
operator being here in the first place. I think it's reasonable for 
ElementCount to provide a built-in function to establish an ordering for these 
purposes, but the function should be named such that nobody thinks the function 
is intended to be the mathematical relation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86065/new/

https://reviews.llvm.org/D86065

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to