rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land.
LGTM modulo the minor fix ================ Comment at: clang/lib/CodeGen/CGDecl.cpp:2107 + // FIXME: When popping normal cleanups, we need to keep this EH cleanup + // around in case a temporary's destructor throws an exception. + if (cleanupKind & EHCleanup) ---------------- Oh, yuck, that's unfortunate. ================ Comment at: clang/lib/CodeGen/CGDecl.cpp:2117 + + // Otherwise, we should only destroy the object if its been initialized. + // Re-use the active flag and saved address across both the EH and end of ---------------- "it's" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86854/new/ https://reviews.llvm.org/D86854 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
