gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/AST/IgnoreExpr.h:15
+namespace clang {
+namespace {
+/// Given an expression E and functions Fn_1,...,Fn_n : Expr * -> Expr *,
----------------
Each occurrence of unnamed namespace creates separate entities, so we would 
have ODR violations in `IgnoreExprNodes`.


================
Comment at: clang/include/clang/AST/IgnoreExpr.h:37
+
+Expr *IgnoreImpCastsSingleStep(Expr *E);
+
----------------
Expand "Imp" to "Implicit"? (Here and one more below.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86778/new/

https://reviews.llvm.org/D86778

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to