wristow added inline comments.
================ Comment at: clang/lib/AST/ExprConstant.cpp:3098 // have been value-dependent too), so diagnose that. - assert(!VD->mightBeUsableInConstantExpressions(Info.Ctx)); + assert(!VD->isUsableInConstantExpressions(Info.Ctx)); if (!Info.checkingPotentialConstantExpression()) { ---------------- This looks like a more appropriate assertion-check to me. But it's out of my area of experience, so I don't feel qualified to give an authoritative "LGTM". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86649/new/ https://reviews.llvm.org/D86649 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits