ebevhan added inline comments.
================ Comment at: clang/lib/AST/ASTContext.cpp:10963 +bool +ASTContext::isExplicitAddrSpaceConversionLegal(LangAS From, LangAS To) const { + // If From and To overlap, the cast is legal. ---------------- ebevhan wrote: > Anastasia wrote: > > Btw I assume that explicit cast can't reject what is not rejected by > > implicit cast? > > > > I am not sure if we need to enforce or document this somehow considering > > that we provide full configurability now? > It shouldn't do that, no. I don't think there's any way to guarantee this, > though. > > I could add something to the target methods about it. Wait, no. This is already guaranteed, because the method here in ASTContext will check for overlap first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://reviews.llvm.org/D62574 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits