MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

I am still reading the patch, but I have noticed one thing worth discussing. 
`.bb_addr_map` is a non-SHF_ALLOC section (meaning that it is not part of the 
memory image). An absolute relocation type (`.quad   .Lfunc_begin0`) works but 
the value is a link-time address, not taking account of the load base 
(PIE/shared object)). How do you intend to use `.bb_addr_map` at runtime?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85408/new/

https://reviews.llvm.org/D85408

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to