aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM!
================ Comment at: clang/docs/ThreadSafetyAnalysis.rst:804 + #define RELEASE_GENERIC(...) \ + THREAD_ANNOTATION_ATTRIBUTE__(release_generic_capability(__VA_ARGS__)) + ---------------- This is not something you should feel obligated to fix (esp not as part of this patch), but I just realized we have a naming-related UB here in C++ with the trailing double underscores: http://eel.is/c++draft/lex.name#3.1 We should probably pick a different identifier to use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87064/new/ https://reviews.llvm.org/D87064 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
