Xiangling_L added a comment. In D86790#2255371 <https://reviews.llvm.org/D86790#2255371>, @jyknight wrote:
> Do you have open questions on whether some callsites passing "false" here, > should be switched to true? Given what's here, I would say that it definitely > does not makes sense to add this parameter everywhere. Basically, the places where I changed to `true /* NeedsPreferredAlignment */` are ones I'd like reviewers to see if the switch is correct. ================ Comment at: clang/lib/CodeGen/CGAtomic.cpp:814 + std::tie(sizeChars, alignChars) = getContext().getTypeInfoInChars( + AtomicTy, true /* NeedsPreferredAlignment */); uint64_t Size = sizeChars.getQuantity(); ---------------- jyknight wrote: > This is wrong. Can you explain a bit why it's wrong? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86790/new/ https://reviews.llvm.org/D86790 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
