hubert.reinterpretcast added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/ZOS.cpp:25-27
+void ZOS::addClangTargetOptions(const llvm::opt::ArgList &DriverArgs,
+ llvm::opt::ArgStringList &CC1Args,
+ Action::OffloadKind DeviceOffloadKind) const {
----------------
Please be consistent in using/not using additional namespace qualification. The
declaration above this one takes advantage of the using directive for
`llvm::opt`.
================
Comment at: clang/lib/Sema/SemaExprCXX.cpp:1841
- << IsDelete << FD.getType().getAsString() << OSName
- << alignedAllocMinVersion(T.getOS()).getAsString();
Diag(Loc, diag::note_silence_aligned_allocation_unavailable);
----------------
Just to ensure we are on the same page:
Passing `-Xclang -faligned-alloc-unavailable` on the non-Apple platforms does
very bad things (hits "unreachable" and otherwise falls off the end of a
function without initializing a return value). Part of this patch makes passing
`-Xclang -faligned-alloc-unavailable` okay on z/OS.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87611/new/
https://reviews.llvm.org/D87611
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
