zoecarver added inline comments.
================
Comment at: clang/test/CodeGenCXX/builtin-zero-non-value-bits.cpp:160
+
+int main() {
+ testAllForType<32, 16, char>(11, 22, 33, 44);
----------------
jfb wrote:
> Usually CodeGen tests will use lit to check the emitted IR matches
> expectations. I think that's what you want to do here.
>
> Remember to test `volatile` qualified pointers, as well as address spaces too.
What's a good place for me to put this end-to-end test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87974/new/
https://reviews.llvm.org/D87974
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
