NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Aha, yup, thanks, this looks good!
================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:146
+ return SVB.makeLoc(BaseReg);
+ }
+ if (Init->isDelegatingInitializer())
----------------
Whitespace?
================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:378
+ const auto *Init = ICC->getCXXCtorInitializer();
+ assert(Init->isAnyMemberInitializer());
return addObjectUnderConstruction(State, ICC->getCXXCtorInitializer(),
----------------
Let's add some reasoning, eg. "Base and delegating initializers handled above"?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85351/new/
https://reviews.llvm.org/D85351
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
