ZarkoCA added inline comments.
================
Comment at: clang/test/CodeGen/powerpc-c99complex.c:7
+ return x;
+// PPC64LNX-LABEL: define { float, float } @foo1(float %x.{{.*}}, float
%x.{{.*}}) #0 {
+// PPC64LNX: ret { float, float }
----------------
Nit: I don't think you need the `#0` here and anywhere below.
================
Comment at: clang/test/CodeGen/powerpc-c99complex.c:19-20
+ return x;
+// PPC64LNX-LABEL: define { double, double } @foo2(double %x.{{.*}},
double %x.{{.*}}) #0 {
+// PPC64LNX: ret { double, double }
+
----------------
Nit: please line up these lines with the ones below.
================
Comment at: clang/test/CodeGen/powerpc-c99complex.c:34-39
+// PPC32LNX-LABEL: define void @foo3({ ppc_fp128, ppc_fp128 }* noalias sret
align 16 %agg.result, { ppc_fp128, ppc_fp128 }* byval({ ppc_fp128, ppc_fp128 })
align 16 %x) #0 {
+// PPC32LNX: [[RETREAL:%.*]] = getelementptr inbounds { ppc_fp128,
ppc_fp128 }, { ppc_fp128, ppc_fp128 }* %agg.result, i32 0, i32 0
+// PPC32LNX-NEXT: [[RETIMAG:%.*]] = getelementptr inbounds { ppc_fp128,
ppc_fp128 }, { ppc_fp128, ppc_fp128 }* %agg.result, i32 0, i32 1
+// PPC32LNX-NEXT: store ppc_fp128 %{{.*}}, ppc_fp128* [[RETREAL]], align 16
+// PPC32LNX-NEXT: store ppc_fp128 %{{.*}}, ppc_fp128* [[RETIMAG]], align 16
+}
----------------
Nit: Can the formatting be fixed so the lines line up?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88105/new/
https://reviews.llvm.org/D88105
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
