miyuki created this revision. miyuki added reviewers: compnerd, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki requested review of this revision.
Sema::DiagnoseSwiftName uses the constant 12 instead of the corresponding enumerator ExpectedFunctionWithProtoType. This is fragile and will fail if a new value gets added in the middle of the enum. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88164 Files: clang/lib/Sema/SemaDeclAttr.cpp Index: clang/lib/Sema/SemaDeclAttr.cpp =================================================================== --- clang/lib/Sema/SemaDeclAttr.cpp +++ clang/lib/Sema/SemaDeclAttr.cpp @@ -5864,7 +5864,7 @@ if (!F->hasWrittenPrototype()) { Diag(Loc, diag::warn_attribute_wrong_decl_type) << AL - << /* non-K&R-style functions */12; + << ExpectedFunctionWithProtoType; return false; } }
Index: clang/lib/Sema/SemaDeclAttr.cpp =================================================================== --- clang/lib/Sema/SemaDeclAttr.cpp +++ clang/lib/Sema/SemaDeclAttr.cpp @@ -5864,7 +5864,7 @@ if (!F->hasWrittenPrototype()) { Diag(Loc, diag::warn_attribute_wrong_decl_type) << AL - << /* non-K&R-style functions */12; + << ExpectedFunctionWithProtoType; return false; } }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits