compnerd marked an inline comment as done.
compnerd added inline comments.
================
Comment at: clang/lib/Sema/SemaDecl.cpp:2613-2614
SNA->getName(), AMK == Sema::AMK_Override);
+ else if (isa<SwiftPrivateAttr>(Attr) && AMK == Sema::AMK_Override)
+ NewAttr = nullptr;
else if (const auto *OA = dyn_cast<OptimizeNoneAttr>(Attr))
----------------
aaron.ballman wrote:
> Hmm, I'm a bit confused. The attribute is an inheritable attribute, but when
> we try to merge attributes between declarations, we drop it?
Discussed offline - this is dead code. Removed and added a test case to
demonstrate the beahviour.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87720/new/
https://reviews.llvm.org/D87720
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
