ianlevesque added a comment.

I can update the docs @MaskRay, not a problem. I'll tweak the test a little too 
per your comment.

@dberris I think if we wanted to control it in a non-'random' (the crc32 was 
chosen so it would be consistent even though it's not really predictable up 
front) way we'd have to emit some lists of function attributes and use the 
-fxray-attr-list=FILE option to really dial that in. If we wanted entire 
modules we could have the build system apply xray's flags to each module 
differently, but we are unlikely to want to instrument every function of a 
module at the same time so we are back to having to use instruction thresholds 
to cut down on it.  Ultimately I think those two suggestions are legitimate 
alternative use cases but don't, for what we're trying to do, replace this 
strategy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87953/new/

https://reviews.llvm.org/D87953

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to