davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

Looks good. Makes the tsan and instrumentation interaction also cleaner.



================
Comment at: clang/test/CodeGen/code-coverage-tsan.c:1
-/// -fsanitize=thread requires the (potentially concurrent) counter updates to 
be atomic.
-// RUN: %clang_cc1 %s -triple x86_64 -emit-llvm -fsanitize=thread 
-femit-coverage-notes -femit-coverage-data \
+/// -fprofile-update=atmomic (implied by -fsanitize=thread) requires the
+/// (potentially concurrent) counter updates to be atomic.
----------------
Fix typo: atmomic


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87737/new/

https://reviews.llvm.org/D87737

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to