jdoerfert added inline comments.
================ Comment at: clang/test/CodeGen/attr-mustprogress-1.cpp:24 + } +} + ---------------- Now here, and below with `while(1)` I would *not* expect `mustprogress`. ================ Comment at: clang/test/CodeGen/attr-mustprogress-1.cpp:185 + do { + } while (a == b); +} ---------------- Here I would not expect the function attr but the metadata on the second loop. I guess we might want to add the metadata always for loops w/o a constant condition especially because the order of the two loops might be swapped (please add a test). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits