jlebar added a comment. > It should. I did mention in a previous comment that > Looks like the > const-ness check should not be there, either. I need to revise the patch.
Heh, okay. Sorry I missed that, somehow this patch was confusing to me. > Except that NVCC allows non-const __constant__, too. Generally speaking, C++ > does not care about the attributes. While technically __constant__ is not > changeable from the device code, not specifying const is a missed > optimization/diagnostic opportunity, but not an error per se. It does not > affect how the variable is emitted, but rather what user can do with it and > that's beyond the scope of this patch. I don't think it warrants a hard > error. A warning, perhaps, that non-const __constant__ is probably an error? Sure, that makes sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88345/new/ https://reviews.llvm.org/D88345 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
