void added inline comments.
================ Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1679 + // Inlining a function the explicitly should not have a stack protector may + // break the code if inlined into a function that does have a stack ---------------- s/the/that/ ================ Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1682 + // protector. + if (Caller->hasFnAttribute(Attribute::NoStackProtect)) + if (CalledFunc->hasFnAttribute(Attribute::StackProtect) || ---------------- Should we check whether the function with nossp needs an ssp before issuing the error? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
