kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks, LGTM! Should we also have another test for SymbolCollector, to ensure we don't regress this somehow in the future? ================ Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:93 + // Clang requires source to be UTF-8, but doesn't enforce this in comments. + if (!llvm::json::isUTF8(Doc)) + Doc = llvm::json::fixUTF8(Doc); ---------------- it is always surprising to have these helpers in json library :D (just talking out loud) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88567/new/ https://reviews.llvm.org/D88567 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
