venkataramanan.kumar.llvm added a comment. In D88154#2290205 <https://reviews.llvm.org/D88154#2290205>, @abique wrote:
> Looks good to me. > Regarding the tests, it seems that you check if auto-vectorization takes > advantages of libmvec? > Would it be interesting to have a test which declares a vector and call the > builtin sin on it? > > Thank you very much for the changes! :) do we we have built-in support for sin that takes vector types? I tried __m128d compute_sin(__m128d x) { return __builtin_sin(x); } >> error: passing '__m128d' (vector of 2 'double' values) to parameter of >> incompatible type 'double' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88154/new/ https://reviews.llvm.org/D88154 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits