compnerd added a comment. The reason that I added the overlapped event was specifically for the cancellation and overlooked the fact that it will be used by the kernel side as well, thanks for catching that!
================ Comment at: clang/unittests/DirectoryWatcher/CMakeLists.txt:1 -if(APPLE OR CMAKE_SYSTEM_NAME MATCHES "Linux") +if(APPLE OR CMAKE_SYSTEM_NAME MATCHES "Linux" OR CMAKE_SYSTEM_NAME STREQUAL Windows) ---------------- amccarth wrote: > I'm not a Cmake expert, but I"m curious way `MATCHES "Linux"` but `STREQUAL > Windows`. `MATCHES` is a regular expression, and overly expensive. The `STREQUAL` is a string comparison (ala `strcmp`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https://reviews.llvm.org/D88666 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
