nikic added inline comments.
================ Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:560 // Fold away bit casts of the loaded value by loading the desired type. - // We can do this for BitCastInsts as well as casts from and to pointer types, - // as long as those are noops (i.e., the source or dest type have the same - // bitwidth as the target's pointers). + // Note that we should not do this for pointer<->integer casts! if (LI.hasOneUse()) ---------------- You might want to be a tad more explicit here, e.g. add "because they have different provenance" or so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88979/new/ https://reviews.llvm.org/D88979 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
