hokein added inline comments.
================ Comment at: clang/lib/Tooling/Refactoring/Rename/USRFindingAction.cpp:119 + llvm::for_each(PartialSpecs, + [&](const auto *Spec) { addUSRsOfCtorDtors(Spec); }); addUSRsOfCtorDtors(TemplateDecl->getTemplatedDecl()); ---------------- danilaml wrote: > Btw, this breaks on GCC <= 7.1, due to > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67274 > Workaround is to use `this->`. oh, thanks for spotting it! Fixed in e6b4179c5d282905a8ad17c57153b991c42d1126, instead of adding `this->`, I reverted it to the for-range loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89220/new/ https://reviews.llvm.org/D89220 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits